Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed process-nexttick-args as it's not used anymore #354

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Conversation

mcollina
Copy link
Member

It's not used in lib/, just to check if tests pass everywhere.

@vweevers
Copy link
Contributor

A search shows it's still used?

@mcollina
Copy link
Member Author

@vweevers thanks for checking. I've removed it everywhere, let's see what CI says.

@mcollina
Copy link
Member Author

CI seems happy. @vweevers can you please check?

Copy link
Contributor

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 23c4ff0 into master Aug 13, 2018
@mcollina mcollina deleted the remove-deps branch August 13, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants