Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destroy/pump #283

Closed
calvinmetcalf opened this issue May 8, 2017 · 10 comments
Closed

destroy/pump #283

calvinmetcalf opened this issue May 8, 2017 · 10 comments

Comments

@calvinmetcalf
Copy link
Contributor

since pump relies on destroy, we probably want destroy in before we do pump.

@mcollina
Copy link
Member

I would say so, let's wait for nodejs/node#12925 to land.

@mcollina
Copy link
Member

mcollina commented Jun 6, 2017

Relevant issues:

mafintosh/pump#17
nodejs/node#1834

@calvinmetcalf
Copy link
Contributor Author

I have a pull I've started a bit back that I can clean up with a bit and submit it, I was waiting on destroy to land first

@mcollina
Copy link
Member

mcollina commented Jun 6, 2017

@calvinmetcalf I think you can fire that, and we can discuss it in the issue tracker.

@calvinmetcalf
Copy link
Contributor Author

calvinmetcalf commented Jun 6, 2017 via email

@calvinmetcalf
Copy link
Contributor Author

nodejs/node#13506

@SimenB
Copy link
Member

SimenB commented Aug 21, 2017

Any news here? Or is it blocked on landing in node core? Would love to be able to just depend on readable stream 🙂

@mcollina
Copy link
Member

@SimenB it's just work that needs doing. Do you want to help a bit?

@SimenB
Copy link
Member

SimenB commented Aug 21, 2017

My understanding of stream internals are next to none, so I'm unfortunately not much help with that 🙁

@prog1dev
Copy link

prog1dev commented Mar 20, 2018

mcollina added a commit that referenced this issue Aug 10, 2018
Fixes #283
Fixes #284
Fixes #212
Fixes #297
Fixes #346
Fixes #339
Fixed #335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants