Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @pimterry as collaborator #52665

Closed
benjamingr opened this issue Apr 24, 2024 · 7 comments · Fixed by #52874
Closed

Nominating @pimterry as collaborator #52665

benjamingr opened this issue Apr 24, 2024 · 7 comments · Fixed by #52874
Labels
meta Issues and PRs related to the general management of the project.

Comments

@benjamingr
Copy link
Member

I'd like to nominte @pimterry for the role of collaborator. He has done quite a few critical fixes on our http/http2 stack and it could be good to have more maintainers in that space.

Commits authored on nodejs/node: github.com/nodejs/node/commits?author=pimterry
Pull requests opened: github.com/search?q=author:pimterry+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:pimterry+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Apimterry+org%3Anodejs&type=pullrequests

@nodejs/collaborators @mcollina
@VoltrexKeyva VoltrexKeyva changed the title Nominating @pimterry as collabortor Nominating @pimterry as collaborator Apr 24, 2024
@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Apr 24, 2024
@lpinca
Copy link
Member

lpinca commented Apr 24, 2024 •
edited

Big 👍 from me.

@pimterry
Copy link
Member

Oh wow, thank you all! Much appreciated. Yes, I'd love to become a collaborator and get more involved with everything around HTTP + the related network stack 👍

@RafaelGSS
Copy link
Member

+1 from me

@mhdawson
Copy link
Member

+1 from me.

@ShogunPanda
Copy link
Contributor

+1 here

@benjamingr
Copy link
Member Author

Hey, it looks like this nomination has passed @nodejs/tsc can someone please schedule onboarding :)?

@pimterry
Copy link
Member

pimterry commented May 3, 2024

Awesome! Whoever's available to do the onboarding, you can pick any time from my calendar here - it's more or less any time in EU work hours.

pimterry added a commit to pimterry/node that referenced this issue May 7, 2024
@pimterry
doc: add pimterry to collaborators
d3e09a3 
Fixes: nodejs#52665
@pimterry pimterry mentioned this issue May 7, 2024
Merged
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this issue May 8, 2024
@pimterry @Ch3nYuY
doc: add pimterry to collaborators
9afea16 
Fixes: nodejs#52665
PR-URL: nodejs#52874
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos pushed a commit that referenced this issue May 8, 2024
@pimterry @targos
doc: add pimterry to collaborators
23a0d33 
Fixes: #52665
PR-URL: #52874
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add pimterry to collaborators pimterry/node
7 participants
@ShogunPanda @benjamingr @lpinca @pimterry @mhdawson @RafaelGSS @VoltrexKeyva