From 4cdb24034febc63f1e7767427ecf8b94655f2fbf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Mon, 31 May 2021 20:08:26 +0200 Subject: [PATCH] build: work around bug in MSBuild v16.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This allows to build Node.js at the (temporary) cost of longer build times. Refs: https://github.com/nodejs/node/issues/38872 Refs: https://github.com/dotnet/msbuild/releases/tag/v16.10.0 Refs: https://github.com/dotnet/msbuild/pull/6465 Refs: https://github.com/dotnet/msbuild/issues/6373 PR-URL: https://github.com/nodejs/node/pull/38873 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel Reviewed-By: Gerhard Stöbich --- vcbuild.bat | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vcbuild.bat b/vcbuild.bat index 86788bd8608ae5..77ec9995ae7655 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -364,6 +364,8 @@ if "%target%"=="Build" ( if defined cctest set target="Build" ) if "%target%"=="node" if exist "%config%\cctest.exe" del "%config%\cctest.exe" +@rem TODO(targos): Remove next line after MSBuild 16.10.1 is released. +if "%target%"=="node" set target="Build" if defined msbuild_args set "extra_msbuild_args=%extra_msbuild_args% %msbuild_args%" msbuild node.sln %msbcpu% /t:%target% /p:Configuration=%config% /p:Platform=%msbplatform% /clp:NoItemAndPropertyList;Verbosity=minimal /nologo %extra_msbuild_args% if errorlevel 1 (