Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question]: Is there a timeline for dropping node10 support? #2599

Closed
wraithgar opened this issue Jan 26, 2022 · 6 comments
Closed

[question]: Is there a timeline for dropping node10 support? #2599

wraithgar opened this issue Jan 26, 2022 · 6 comments

Comments

@wraithgar
Copy link
Contributor

We are in the process of updating our support matrix for the npm cli and its dependencies. One of these dependencies, make-fetch-happen, just had its engines field updated to drop node10 support. We'd like to help keep node-gyp up to date on that dependency but it still supports node >= 10.12.0.

Are there plans or is there a timeline for updating this field?

@cclauss
Copy link
Contributor

cclauss commented Jan 26, 2022

@wraithgar
Copy link
Contributor Author

@cclauss that's the nodejs release cycle, nothing on there mentions node-gyp? Does this mean it can drop node10 now and it was just overlooked?

@rvagg
Copy link
Member

rvagg commented Jan 27, 2022

no plans, we can be flexible around npm's needs on this I think, and we should be able to bump it to at least 12.0.0 (unless you want to suggest a later release of 12?)

@MylesBorins
Copy link
Member

Might I suggest this as the engines field

https://github.com/MylesBorins/node-osc/blob/main/package.json#L14

It scoped to versions to 12/14 that support the full esm implementation

@rvagg
Copy link
Member

rvagg commented Jan 27, 2022

sgtm

@wraithgar
Copy link
Contributor Author

#2601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants