docs: Add notes/disclaimers for upgrading the copy of node-gyp that npm uses #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add notes on npm version compatibility for methods to update node-gyp. Also mention that this is tested on npm 8, now that npm 8 exists. (Npm 8 is the same as npm 7 for purposes of these instructions.) Lastly, add a note that one of the methods is simpler/more durable, if only functional for npm 6 and older.
rvagg
reviewed
Jan 6, 2022
rvagg
reviewed
Jan 6, 2022
Use relative (current dir) links, rather than absolute web URLs. Co-authored-by: Rod Vagg <rod@vagg.org>
DeeDeeG
force-pushed
the
caveats-for-npm-upgrade-docs
branch
from
369828a
to
583abb4
Compare
|
Made the links relative, thanks for pointing that out. |
2 tasks
|
sgtm, as mentioned in the previous docs PR, we should try out faster merges on these doc PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Add notes on npm version compatibility for methods to update the copy of node-gyp that npm uses.
Also mention that this is tested on npm 8, now that npm 8 exists. (Npm 8 is the same as npm 7 for purposes of these instructions.)
Lastly, add a note that one of the methods is simpler/more durable, but only functional for npm 6 and older.