New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 11 SDK (10.0.22000) is not supported #2527
Comments
Will this fix be in #2522 because it landed on Aug 30th in https://github.com/nodejs/gyp-next/releases/ |
Please confirm that this issue is fixed in https://github.com/nodejs/node-gyp/releases |
This issue is not fixed in node-gyp@8.3.0
Logs
|
Hi, I think this issue still persists, I experienced it after upgrading to Windows11 && Visual Studio 2022. Full output:
|
Not up to date. node-sass is deprecated so we cannot offer support for it. |
@ShenHongFei Please try again on v8.4.0 node-gyp v8.4.0Features
|
@cclauss This issue is successfully fixed in node-gyp v8.4.0. |
This is not fixed at all. Node-gyp won't compile using the Windows 11 SDK because the code doesn't check for the I request this issue to be reopened. Relevant info: node-gyp/lib/find-visualstudio.js Line 316 in c2a1850
|
Please look in your logs for the version of node-gyp is running. |
8.4.0, of course! I do use VS2022 |
The current version is v8.4.1. Please provide the command typed and the full logs. |
While I do understand your request, I must say, it is clear as day that the code will not find the Windows 11 SDK because the package prefix changed a Full logs and commands typed are, therefore, useless to this scope. You could run your But, with patience, I will upgrade to the latest node-gyp and post the full logs in the coming days. |
I can also confirm that this issue is not fixed for me. Here is the full output (where you can see the command typed and the full log of the generated output) using node-gyp@8.4.1 and node@16.13.0: npm ERR! command C:\Windows\system32\cmd.exe /d /s /c node-gyp-build || npm run build:libzmq Hope this helps to fix it. |
Did you |
Yes I did. Here is the extract from my .npmrc file: msvs_version=2022 I agree to @NyaomiDEV that this is not a problem of MSVS, but a problem of the Windows SDK. MSVS 2022 is found, but the latest Windows SDK for Windows 11 is not detected as the log output clearly states:
When I install the latest Windows SDK for Windows 10, everything works as expected. |
A pull request to fix this would be warmly received. |
@cclauss Would you please reopen this issue? I am working on a pull request now. |
When I run npm install facing same issue with new versions, Any one please help. npm ERR! path E:\web development\skuad\talent-view-service\node_modules\node-rdkafka |
this fixes missing SDK build error on windows see nodejs/node-gyp#2527
this fixes missing SDK build error on windows see nodejs/node-gyp#2527
Node Version: 16.11.1
Platform:
OS Name: Microsoft Windows 11 Pro
OS Version: 10.0.22000 N/A Build 22000
System Type: x64-based PC
Compiler:
C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133
msbuild: 16.11.1.47101
cl: 19.29.30136
Module: winax
Verbose output (from npm or node-gyp):
node-gyp/lib/find-visualstudio.js#getSDK
could not recognizeMicrosoft.VisualStudio.Component.Windows11SDK.22000
ininfo.packages
because the patternconst win10SDKPrefix = 'Microsoft.VisualStudio.Component.Windows10SDK.'
doesn't match.my
info.packages
contrainsAfter I changed this line https://github.com/nodejs/node-gyp/blob/master/lib/find-visualstudio.js#L184
to
ret.sdk = '10'
node-gyp configure
andnode-gyp build
could run successfully.The text was updated successfully, but these errors were encountered: