Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test broken for node v0.10.x on windows. #1513

Closed
Rohithzr opened this issue Jul 25, 2018 · 1 comment
Closed

Test broken for node v0.10.x on windows. #1513

Rohithzr opened this issue Jul 25, 2018 · 1 comment

Comments

@Rohithzr
Copy link
Contributor

Issue created for reference only

Node.js v0.10 doesn't have a child_process.execFileSync method: https://nodejs.org/docs/latest-v0.10.x/api/child_process.html

@richardlau It looks like #1203 has inadvertently broken this test on v0.10 (prior to that PR the test used execFile which does exist in v0.10).

see discussions on #1492
fixed by #1492

node - v0.10.x
npm - v2.51.x

Details regarding the fix

test/processExecSync.js adds a function that will emulate the child_process.execSync for legacy node <= 0.10.x

the function runs the given command, saves the [stdout, stderr] and the command status in a temp directory then reads the files to get the output of the said commands.

the function deletes the temp files and folders after the task is complete.

@Rohithzr
Copy link
Contributor Author

fixed by #1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant