Build failure when builddir contains spaces. #65

jasondavies · 2012-05-16T19:12:06Z

Proposed Solution (lines 311+), from @trentm:

Old

argv.push('-Dnode_root_dir=' + nodeDir)
argv.push('-Dmodule_root_dir=' + process.cwd())

Fixed

Add:

function shellEscape(str) {
   return str.replace(/(["\s'$`\\])/g, '\\$1');
};

Change to:

argv.push('-Dnode_root_dir=' + shellEscape(nodeDir))
argv.push('-Dmodule_root_dir=' + shellEscape(process.cwd()))

Maybe I am missing something? My only confirmation that it is still not working is from the issue I made on another repository: nodegit/nodegit#123

Hope this can be resolved and merged soon!

Update:
Looks like the solution didn't completely work. Sorry for the false alarm 👎 .

@trentm

Fixes nodejs#65. Build failure when builddir contains spaces. Solution by @trentm. See trentm@bbd979b

sebnapi · 2014-05-28T23:44:11Z

This is an Open Issue:

> fsevents@0.2.0 install /usr/local/lib/node_modules/karma/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

make: *** No rule to make target `../../../../../../../../../../Volumes/Macintosh', needed by `Makefile'.  Stop.
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.EventEmitter.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:807:12)
gyp ERR! System Darwin 13.2.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/lib/node_modules/karma/node_modules/chokidar/node_modules/fsevents
gyp ERR! node -v v0.10.28
gyp ERR! node-gyp -v v0.13.0
gyp ERR! not ok

workaround not working for me too

kfancy · 2014-08-01T21:12:37Z

Work-around (definitely OS X, probably unix*) until this is fixed:

create a new account, with no spaces in the folder name
log in as that user
install globally:

npm install -g PACKAGENAME

(this worked for me, to install zmq)

carstenhag · 2015-01-23T20:54:31Z

Bump I guess? This still is an issue afaik.

Mike-Dunton · 2015-02-03T20:01:13Z

I am still having this issue here is a log output.

lwip@0.0.5 install /Users/michael dunton/projects/optimlol/node_modules/css-sprite/node_modules/lwip
> node-gyp rebuild

  CXX(target) Release/obj.target/lwip_decoder/src/decoder/init.o
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/src'
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/deps/uv/include'
clang: error: no such file or directory: 'dunton/.node-gyp/0.10.36/deps/v8/include'
make: *** [Release/obj.target/lwip_decoder/src/decoder/init.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/michael dunton/projects/optimlol/node_modules/css-sprite/node_modules/lwip
gyp ERR! node -v v0.10.36
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok

freder · 2015-03-30T13:09:02Z

yep, still an issue:

clang: error: no such file or directory: 'HD'
clang: error: no such file or directory: '2/Projects/bla/code/bla.js/node_modules/libxslt/node_modules/libxmljs/src'
clang: error: no such file or directory: 'HD'
clang: error: no such file or directory: '2/Projects/bla/code/bla.js/node_modules/libxslt/node_modules/libxmljs/vendor/libxml/include'
make: *** [Release/obj.target/libexslt/deps/libxslt/libexslt/common.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:269:23)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1067:12)

Zae · 2015-06-09T10:58:46Z

Any progress on this?

nemoDreamer · 2015-06-29T14:47:03Z

👍 Not just a Windows issue: I'm trying to install an Atom plug-in that uses node-gyp as a dependency, and my ~/.atom is stored on my cloud, by symlinking it to my "Google Drive" folder. I can't exactly rename that folder to not have a space, as it's tied into Google Drive's software...

Seems like this is a case for delimiting strings using a null character rather that splitting at spaces, kind of like find . -print0 | xargs -0 ... does, no?

davidrhoderick · 2015-07-15T16:45:18Z

Still an issue on Mac OS X 10.9.5.

kfancy · 2015-07-15T17:02:45Z

It's probably going to remain an issue, my recommendation is to either
create a separate account to install global modules as necessary, or go
through the steps of removing the space from your user account directory
name, steps outlined in the link below.

https://support.apple.com/en-us/HT201548

On Wed, Jul 15, 2015 at 9:45 AM, David Rhoderick notifications@github.com
wrote:

Still an issue on Mac OS X 10.9.5.

—
Reply to this email directly or view it on GitHub
#65 (comment)
.

theDevelopper · 2021-07-16T12:53:05Z

i cannot use node-gyp on Windows 10 Pro because of spaces in folder names. I cannot change the folders names.
It happens for me when a python process is being spawned, but the passed arguments/parameters are not escaped.

This removes the msvs_enable_marmasm configuration option that becomes unnecessary. Closes: nodejs/gyp-next#64

julienfdev · 2021-09-09T07:43:11Z

Same issue here, can't build on Big Sur when path contains spaces and I have no control on the folder name

cclauss · 2021-09-09T07:56:22Z

@jasondavies macOS workaround above #65 (comment)

julienfdev · 2021-09-09T08:58:52Z

Thanks, that's not exactly the problem, I should have explained it better :
I never include spaces in my folder names, the problem comes from the /Mobile Documents/ (iCloud), it's located at
${HOME}/Library/ so setting the HOME variable won't do the trick. 🤷‍♂️

cclauss · 2021-09-09T09:17:23Z

Use backslash… HOME="/Mobile\ Documents/"

julienfdev · 2021-09-09T09:23:18Z

Thanks Christian but that won't work.
The problem is not that node-gyp is trying to write temp files in a HOME path containing spaces that need escaping (what the HOME workaround actually fixes), the problem is when gyp is trying to access a file at a path containing spaces, doesn't matter if it's located in your home directory or not, it's not using the HOME variable at all when resolving this path.

Looks like there's nothing we can do about it as the problem comes from gyp itself, not node-gyp 😐

jessejiang0214 · 2022-05-25T05:39:59Z

Cannot believe this bug has existed for 10 years!!!
This still exists in v9.0.0 on MacOS

hungtcs · 2022-06-16T09:04:12Z

Cannot believe this bug has existed for 10 years!!! This still exists in v9.0.0 on MacOS

When I move my projects to a mobile hard disk, I have a problem from 10 years ago

davej · 2022-06-27T19:09:29Z

By the way, I created a PR for this last year but it hasn't seen any movement: #2556

hungtcs · 2022-06-28T02:37:34Z

By the way, I created a PR for this last year but it hasn't seen any movement: #2556

It looks so easy to fix.

relativeflux · 2022-10-25T22:55:50Z

Can this be looked at, please?

cclauss · 2022-10-26T08:30:07Z

Can we have a GitHub Action that fails which demonstrates this problem? Which pull request should be reviewed?

Fix an installation issue that occurs when a path in which node-gyp is run contains spaces. For a path like `my app`, it would error with this message: ``` clang: error: no such file or directory: 'app/node_modules/node-addon-api' ``` The "my" part before the space (and the rest of the path before it) would be missing from the path in the error message. Fixes nodejs/node-gyp#65

TooTallNate mentioned this issue Jul 5, 2012

Build fails if path contains spaces #93

Closed

TooTallNate mentioned this issue Oct 21, 2012

Install fails when there's a space in .node-gyp path kelektiv/node.bcrypt.js#121

Closed

chrisa mentioned this issue Nov 6, 2012

Can't compile in mac osx lion chrisa/node-dtrace-provider#25

Closed

trentm mentioned this issue Nov 15, 2012

Installing fails when there is a space in the path trentm/node-bunyan#58

Closed

trentm added a commit to trentm/node-gyp that referenced this issue Nov 15, 2012

issue nodejs#65: fix some shell escaping for building in a dir with s…

bbd979b

…paces

trentm mentioned this issue Nov 14, 2013

Fails to build if there's a space in the directory tree chrisa/node-dtrace-provider#37

Closed

Glavin001 added a commit to Glavin001/node-gyp that referenced this issue Jan 6, 2014

Update configure.js

6bfb29b

Fixes nodejs#65. Build failure when builddir contains spaces. Solution by @trentm. See trentm@bbd979b

This was referenced Jan 6, 2014

Fixes #65, Build failure when builddir contains spaces. #381

Closed

issue #65: fix some shell escaping for building in a dir with spaces #164

Closed

Cannot install because space is in directory. Coders-Classroom/Coders-Classroom#11

Closed

julianbrowne mentioned this issue Apr 23, 2014

install in directory where parent directory has spaces 3rd-Eden/node-hashring#18

Closed

thomasjo mentioned this issue Aug 1, 2014

Can't install "Atom Lint" because of a space in my hard disk name atom/atom#3147

Open

smikes mentioned this issue Nov 17, 2014

Errors Installing Ember App Kit npm/npm#4002

Closed

kkoopa mentioned this issue Dec 19, 2014

Fails to install on Mac OSX, if filepath has a space in it. brianmcd/contextify#128

Closed

thomasjo mentioned this issue May 8, 2015

Build issues on Windows 8.1 electron/electron#1623

Closed

cyj5230 mentioned this issue Jun 2, 2021

Cannot install via npm when there is space in system username BYVoid/OpenCC#595

Closed

lovell mentioned this issue Jul 2, 2021

Regression: installation fails when space in path lovell/sharp#2777

Closed

targos added a commit to targos/node-gyp that referenced this issue Aug 22, 2021

win: auto-include marmasm sections for Windows on ARM (nodejs#65)

88f105e

This removes the msvs_enable_marmasm configuration option that becomes unnecessary. Closes: nodejs/gyp-next#64

Brady-Adcock mentioned this issue Oct 26, 2021

set-up dev environment AgileAppstate/moss3-classroom-assistant#1

Open

davej added a commit to davej/node-gyp that referenced this issue Nov 25, 2021

fix: failure when build directory contains spaces (nodejs#65)

fc480dd

Prinzhorn mentioned this issue Dec 2, 2021

Getting Error while installing Better-Sqlite3 on a Raspberry PI WiseLibs/better-sqlite3#547

Closed

JoshuaWise mentioned this issue May 6, 2022

Trouble Installing on Node 17 WiseLibs/better-sqlite3#795

Closed

danielvy mentioned this issue Sep 7, 2022

Unable to connect to SQLite database mtxr/vscode-sqltools#921

Closed

gjsjohnmurray mentioned this issue Sep 7, 2022

Can't install in node on linux/arm64 on Apple Silicon ARM64 M1 - because of missing binary TryGhost/node-sqlite3#1413

Closed

This was referenced Oct 6, 2022

Installation from source fails if there is a space in the path to working directory kelektiv/node.bcrypt.js#961

Open

Build failure due to spaces in path nodejs/gyp-next#180

Open

mischnic mentioned this issue Jan 18, 2023

Can't install parcel parcel-bundler/parcel#8772

Closed

Cefold mentioned this issue Feb 15, 2023

Add basename option electron/packager#1478

Closed

5 tasks

chronic8000 mentioned this issue May 3, 2023

Node.js version error dikkietrom/KITT-AI-Browser#1

Open

tombruijn mentioned this issue Aug 16, 2023

Fix installation to paths with spaces appsignal/appsignal-nodejs#907

Closed

tombruijn mentioned this issue Aug 17, 2023

fix: failure when build directory contains spaces nodejs/gyp-next#204

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build failure when builddir contains spaces. #65

Build failure when builddir contains spaces. #65

jasondavies commented May 16, 2012

TooTallNate commented May 16, 2012

TooTallNate commented Jul 10, 2012

cshenoy commented Oct 15, 2012

trentm commented Nov 15, 2012

jmwohl commented Nov 12, 2013

Glavin001 commented Jan 6, 2014

sebnapi commented May 28, 2014

kfancy commented Aug 1, 2014

carstenhag commented Jan 23, 2015

Mike-Dunton commented Feb 3, 2015

freder commented Mar 30, 2015

Zae commented Jun 9, 2015

nemoDreamer commented Jun 29, 2015

davidrhoderick commented Jul 15, 2015

kfancy commented Jul 15, 2015

theDevelopper commented Jul 16, 2021

julienfdev commented Sep 9, 2021

cclauss commented Sep 9, 2021

julienfdev commented Sep 9, 2021

cclauss commented Sep 9, 2021 •

edited

julienfdev commented Sep 9, 2021

jessejiang0214 commented May 25, 2022

hungtcs commented Jun 16, 2022

davej commented Jun 27, 2022

hungtcs commented Jun 28, 2022

relativeflux commented Oct 25, 2022

cclauss commented Oct 26, 2022 •

edited

Build failure when builddir contains spaces. #65

Build failure when builddir contains spaces. #65

Comments

jasondavies commented May 16, 2012

TooTallNate commented May 16, 2012

TooTallNate commented Jul 10, 2012

cshenoy commented Oct 15, 2012

trentm commented Nov 15, 2012

jmwohl commented Nov 12, 2013

Glavin001 commented Jan 6, 2014

Proposed Solution (lines 311+), from @trentm:

Old

Fixed

sebnapi commented May 28, 2014

kfancy commented Aug 1, 2014

carstenhag commented Jan 23, 2015

Mike-Dunton commented Feb 3, 2015

freder commented Mar 30, 2015

Zae commented Jun 9, 2015

nemoDreamer commented Jun 29, 2015

davidrhoderick commented Jul 15, 2015

kfancy commented Jul 15, 2015

theDevelopper commented Jul 16, 2021

julienfdev commented Sep 9, 2021

cclauss commented Sep 9, 2021

julienfdev commented Sep 9, 2021

cclauss commented Sep 9, 2021 • edited

julienfdev commented Sep 9, 2021

jessejiang0214 commented May 25, 2022

hungtcs commented Jun 16, 2022

davej commented Jun 27, 2022

hungtcs commented Jun 28, 2022

relativeflux commented Oct 25, 2022

cclauss commented Oct 26, 2022 • edited

cclauss commented Sep 9, 2021 •

edited

cclauss commented Oct 26, 2022 •

edited