Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run Windows CI only on nondeprecated build configurations #1152

Merged
merged 1 commit into from Mar 21, 2022

Conversation

RaisinTen
Copy link
Contributor

@RaisinTen RaisinTen commented Mar 19, 2022

The windows-2016 runner has been deprecated on March 15, 2022. That is
why those runs are getting cancelled recently. This change fixes the
issue by removing that runner from the config.

Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022
Signed-off-by: Darshan Sen raisinten@gmail.com

cc @mhdawson

The windows-2016 runner has been deprecated on March 15, 2022. That is
why those runs are getting cancelled recently. This change fixes the
issue by removing that runner from the config.

Refs: https://github.blog/changelog/2021-10-19-github-actions-the-windows-2016-runner-image-will-be-removed-from-github-hosted-runners-on-march-15-2022
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen changed the title build: run Windows CI on all nondeprecated build configurations build: run Windows CI only on nondeprecated build configurations Mar 19, 2022
@mhdawson
Copy link
Member

@RaisinTen thanks for the change. @richardlau I think you dealt with a similar issue in other tests. Can you remind me how you handled that. Just want to confirm removing is the way we want to go.

@richardlau
Copy link
Member

richardlau commented Mar 21, 2022

@RaisinTen thanks for the change. @richardlau I think you dealt with a similar issue in other tests. Can you remind me how you handled that. Just want to confirm removing is the way we want to go.

For Node.js core we had Node.js 12 being tested on "windows-2016" and nothing else for which I bumped that to "windows-2019" (nodejs/node#42349). Node.js 14 was using "windows-latest" and I had to pin that to "windows-2019" (nodejs/node#42350) as Node.js 14 currently cannot detect Visual Studio 2022. Neither of those cases appear to apply here, so this change LGTM.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 0127496 into nodejs:main Mar 21, 2022
@mhdawson
Copy link
Member

@RaisinTen thanks for fixing this up :)

@RaisinTen RaisinTen deleted the windows-ci branch March 21, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants