Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Testing coverage for Objects #936

Closed
JckXia opened this issue Mar 17, 2021 · 5 comments
Closed

[Tests] Testing coverage for Objects #936

JckXia opened this issue Mar 17, 2021 · 5 comments

Comments

@JckXia
Copy link
Member

JckXia commented Mar 17, 2021

class methods
See #923 (covered) Object New(size_t argc, const napi_value* args) const
Object (Covered under #923) Object()
See #923 Object(napi_env env, napi_value value)
Covered PropertyLValuestd::string operator [](const char* utf8name)
Covered PropertyLValuestd::string operator [](const std::string& utf8name)
Covered PropertyLValue<uint32_t> operator [](uint32_t index)
See #923 (covered) Value operator [](const char* utf8name) const
See #923 (covered) Value operator [](const std::string& utf8name) const
See #923 (covered) Value operator [](uint32_t index) const
Covered bool Has(uint32_t index) const
See #194 (Covered) bool Has(napi_value key) const
See #194 (Covered) bool Has(Value key) const
See #194 (Covered) bool Has(const char* utf8name)
See #194 (Covered) bool Has(const std::string& utf8name)
Covered Value Get(uint32_t index) const
See #183 (Covered) Value Get(napi_value key) const
See #183 (Covered) Value Get(Value key) const
See #183 (Covered) Value Get(const char* utf8name)
See #183 (Covered) Value Get(const std::string& utf8name)
Covered bool Delete(uint32_t index)
See #183 (Covered) bool Delete(napi_value key)
See #183 (Covered) bool Delete(Value key)
See #183 (Covered) bool Delete(const char * utf8name)
See #183 (Covered) bool Delete(const std::string& utf8name)
See #1130 (Covered) template void Set(uint32_t index, const ValueType& value)
See #183 (Covered) template void Set(napi_value key, const ValueType& value)
See #183 (Covered) template void Set(Value key, const ValueType& value)
See #183 (Covered) template void Set(const char* utf8name, const ValueType& value)
See #183 (Covered) template void Set(const std::string& utf8name, const ValueType& value)
See #29 (covered) void DefineProperty(const std::vector& properties)
See #29 (covered) void DefineProperties(const std::initializer_list& properties)
See #29 (covered) void DefineProperties(const PropertyDescriptor& property)
Covered bool InstanceOf(const Function& constructor) const
Object::PropertyLValue (Uncovered) operator Value() const
See #923 (covered) template PropertyLValue& operator =(ValueType value)
See #551 (covered) template<typename Finalizer, typename T, typename Hint> void AddFinalizer(Finalizer, finalizeCallback, T* data, Hint* finalizeHint)
See #551 (covered) template<typename Finalizer, typename T> void AddFinalizer(Finalizer finalizeCallback, T* data);
See #60 (covered) Napi::Array Napi::Object::GetPropertyNames() const
@NickNaso NickNaso added the test label Mar 17, 2021
@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jun 16, 2021
@mhdawson mhdawson removed the stale label Jun 17, 2021
@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@JckXia
Copy link
Member Author

JckXia commented Jul 28, 2022

Looks like we have full coverage for objects. Closing this issue

@JckXia JckXia closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants