Add missing methods to Nan::Maybe<T> #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 1, 2019
LinusU
approved these changes
May 1, 2019
kkoopa
approved these changes
May 8, 2019
nan.h
Outdated
| #if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 4 || \ | ||
| (V8_MAJOR_VERSION == 4 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 3)) | ||
| // Allow implicit conversions from v8::Maybe<T> to Nan::Maybe<T>. | ||
| Maybe(const v8::Maybe<T>& that) |
There was a problem hiding this comment.
can you add a comment for the linter to suppress warnings about runtime/explicit here
There was a problem hiding this comment.
Done, sorry about that. I added a second commit that fixes all the other style violations.
Nan::Maybe<T> was an alias for v8::Maybe<T> with most Node.js versions but that's problematic because v8::Maybe<T> has grown new methods over time that are missing in older versions. From now on we use our custom Maybe<T> implementation with all Node.js versions. This commit also adds the following missing methods: * Maybe<T>::Check() const * Maybe<T>::To(T*) const * Maybe<T>::ToChecked() const Fixes: #851
The code base is now `make lint`-clean again.
|
Even better. Thanks. |
|
@kkoopa Is there a reason you squashed the commits? Not that it really matters, I'm just curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nan::Maybe was an alias for v8::Maybe with most Node.js versions
but that's problematic because v8::Maybe has grown new methods over
time that are missing in older versions.
From now on we use our custom Maybe implementation with all Node.js
versions. This commit also adds the following missing methods:
Fixes: #851