Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get hooked up to the node.js CI infrastructure? #508

Open
kkoopa opened this issue Nov 3, 2015 · 4 comments
Open

Can we get hooked up to the node.js CI infrastructure? #508

kkoopa opened this issue Nov 3, 2015 · 4 comments

Comments

@kkoopa
Copy link
Collaborator

kkoopa commented Nov 3, 2015

As @bnoordhuis mentioned, it might be possible to get us hooked up to the node.js CI infrastructure.

In general, this could be very nice.

From a personal point of view, my main concerns are with ease of use and speed.

  • Will it be at least as fast as Travis, given queues and whatnot?
  • Is it possible to hook the CI infrastructure into the GitHub API?

Are CI builds done automatically or manually in node.js?
If they are started manually, the second point above is less important. We could then rely on the current setup for everyday use and do occasional manual checks on a big-endian machine before publishing new versions or merging PRs which might run into endianness problems.

I guess a manual build setup would be easier for the node.js infrastructure team to pull off and would produce less overhead and noise.

/cc @rvagg

@bnoordhuis
Copy link
Member

/cc @nodejs/build

@bnoordhuis
Copy link
Member

Will it be at least as fast as Travis, given queues and whatnot?

Yes in general. Some of the arm buildbots are pretty slow though.

Are CI builds done automatically or manually in node.js?

At the moment: manually.

@kkoopa
Copy link
Collaborator Author

kkoopa commented Nov 3, 2015

Some of the arm buildbots are pretty slow though.

If they run in parallel, I don't think it should be too much of a problem. If it is less than five minutes, it should probably be fine. If we end up only doing occasional one-off builds on a big-endian machine, the speed should be of no concern. Also, building NAN's test suite should be a far cry from building V8 + node.js + libuv.

EDIT:
This could also make it far easier to test against nightlies and V8-next branches. You do still make nightlies, right?

@tniessen
Copy link
Member

See also #958.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants