Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

http_parser_parse_url fails to handle very long URLs #481

Open
piru opened this issue May 9, 2019 · 0 comments
Open

http_parser_parse_url fails to handle very long URLs #481

piru opened this issue May 9, 2019 · 0 comments

Comments

@piru
Copy link

piru commented May 9, 2019

http_parser_parse_url quietly fails to parse very long URLs. Instead it will return invalid off and len values. There could be a security impact in this issue in situations where the parse result data would be used to make security related decisions (for example the parsed path might be different in actual URL vs the parsed one).

PR #480 is a proposed fix to this issue. Alternatively if the existing ABI must be maintained, the code should be changed to return an error if off or len overflow (become > UINT16_MAX).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant