Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nodegyp-test-pull-request #747

Closed
refack opened this issue Jun 6, 2017 · 6 comments
Closed

update nodegyp-test-pull-request #747

refack opened this issue Jun 6, 2017 · 6 comments

Comments

@refack
Copy link
Contributor

refack commented Jun 6, 2017

Re: nodejs/node-gyp#1212

  1. We should add node8 to the fan
  2. For node-gyp@4.x.x we will only support node >= 4
    node-gyp@3 will go into "LTS"

So I assume we need a matrix?

@bnoordhuis
Copy link
Member

I wasn't planning on maintaining branches for v0.10 and v0.12 once we bump major. Was anyone else and if so, why?

@joaocgreis
Copy link
Member

  • Added Node version 8
  • Node versions 0.x will only run if node-gyp < 4 (so this will simply work if we ever create a v3.x branch)

I believe that takes care of it, so I'll close. Please reopen if I missed something.

@refack
Copy link
Contributor Author

refack commented Jun 6, 2017

I wasn't planning on maintaining branches for v0.10 and v0.12 once we bump major. Was anyone else and if so, why?

nodejs/node-gyp#1212 (comment) If someone finds a new bug (especially on Windows, "Windows user are not happy" and all that Jazz) 🤷‍♂️ personally I have no problem helping them.
So maybe LTS is the wrong comparison, more like "lazy-copy-on-write-maintenance"?

@refack
Copy link
Contributor Author

refack commented Jun 6, 2017

@refack
Copy link
Contributor Author

refack commented Jun 6, 2017

Re: nodejs/node-gyp@75cfae2
If I jumped the gun, shoot me.

@gibfahn
Copy link
Member

gibfahn commented Jun 6, 2017

So maybe LTS is the wrong comparison, more like "lazy-copy-on-write-maintenance"?

I think the right statement is "we might consider doing another release on a case-by-case basis".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants