Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 12 infrastructure checklist #1768

Closed
20 of 25 tasks
rvagg opened this issue Apr 16, 2019 · 7 comments
Closed
20 of 25 tasks

Node.js 12 infrastructure checklist #1768

rvagg opened this issue Apr 16, 2019 · 7 comments

Comments

@rvagg
Copy link
Member

rvagg commented Apr 16, 2019

Release

Test

Miscellaneous

@rvagg
Copy link
Member Author

rvagg commented Apr 16, 2019

@nodejs/build I need some help in filling out the OP here with links and info and also getting these items ticked off the list. There's a bunch that are ready for ticking but need confirmation from the relevant expert(s). There's also a bunch that haven't even been started or are only partially done. If you want to put up your hand for something but don't have access, speak up and we'll see if it can be arranged.

@mhdawson
Copy link
Member

I've checked the ones for IBM platforms. We are still working to see if we can get centos in place on PPC, however, the current plan is to switch over after 12.x is cut. GCC6 is installed on the existing PPC machines and it is being used to build/test for 12.x and higher. AIX was already using GCC6 and we have installed and are now using the devtoolset 6 on s390 for 12.x and higher.

@rvagg
Copy link
Member Author

rvagg commented Apr 17, 2019

I'm pretty sure we have x64 sorted out now. I have smartos and armv7 in progress, have updated OP to link to the PRs for them.

@rvagg
Copy link
Member Author

rvagg commented Apr 17, 2019

@joaocgreis would you mind ticking off the windows items if you think they're good as they are?

@joaocgreis
Copy link
Member

Done, AFAICT Windows is ready.

@rvagg
Copy link
Member Author

rvagg commented Apr 18, 2019

Getting very close, I have a smartos18 ansible PR that needs landing, one for the scaleway machines to only run Debian stretch, I (or someone else) needs to cast another eye over linux-x64 to confirm that only gcc-6 and devtoolset-6 are only being invoked for Node 12 (this isn't super critical but it'd be nice to have a smooth path when we start getting new libstdc++ features in and gcc-4.9 breaks). BUILDING.md is almost done. There's a PR for -mmacosx-version-min=10.10.

The two most critical pieces outstanding are: macOS 10.13 for test and release, and Python 2/3 stuff.

Unofficial-builds comes up after all that as non-critical, and I'll be moving my focus back over to that once all of my other active stuff is sorted out.

rvagg added a commit to nodejs/node that referenced this issue Apr 18, 2019
PR-URL: #27275
Refs: #26714
Refs: nodejs/build#1768
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg
Copy link
Member Author

rvagg commented Apr 18, 2019

Time to draw a line under this stuff. As per nodejs/node#26714 (comment) we've failed on Python 3 and macOS 10.13 + Xcode 10. The rest seems to be mostly in order. There is a need to check over all our Linux x64 test machines to make sure that Node 12+ is being compiled with GCC 6+ but I don't consider this critical for release, just something that should be done before we discover it broken with a V8 upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants