Get ndkVersion from main projects' gradle config #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staltz is it ok to add this line in build.gradle? Is there a reason why it was missing ndkVersion? |
|
I have not tested this, but I think this is a good change to make. Without this nodejs-mobile will use the default version of NDK to build native modules, not the ndk version specified in the project |
|
Yes, it's a good PR! Sorry it took a while to review and merge. |
|
Released version 0.8.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was facing a problem in my main project when syncing with gradle files
(androidProjectResult.androidProject::getNdkVersion, "") must not be nullThis PR is a fix for that