Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svg: fix "push after EOF" error #53

Merged
merged 3 commits into from Mar 18, 2021
Merged

svg: fix "push after EOF" error #53

merged 3 commits into from Mar 18, 2021

Conversation

misos1
Copy link
Contributor

@misos1 misos1 commented Mar 18, 2021 •
edited

Fixes #52.

Also adds test case which fails without this patch:

  1) probeStream
       should not fail when processing svg in multiple chunks:
     Uncaught Error [ERR_STREAM_PUSH_AFTER_EOF]: stream.push() after EOF
  2) probeStream
       should not fail when processing svg in multiple chunks:
     Error: done() called multiple times in test <probeStream should not fail when processing svg in multiple chunks> of file probe-image-size/test/test_stream.js

@puzrin puzrin merged commit 5aa8410 into nodeca:master Mar 18, 2021
@puzrin puzrin changed the title fix push after EOF error svg: fix "push after EOF" error Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzrin puzrin puzrin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERR_STREAM_PUSH_AFTER_EOF in probe-image-size/lib/parse_stream/svg.js:163:20
2 participants
@misos1 @puzrin