Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Plain Style support #557

Closed
wants to merge 4 commits into from
Closed

Conversation

Himura2la
Copy link
Contributor

@Himura2la Himura2la commented Jun 15, 2020

The test in #521 is invalid, and did not test the real quotation cases.

I fixed the test and changed the isPlainSafe function so that it follows the specs more precisely.

Although, I still don't understand why specs exclude s-white from ns-plain-char:

[34]            ns-char ::= nb-char - s-white
[127]  ns-plain-safe(c) ::= c = flow-out ⇒ ns-plain-safe-out
                            ...
[128] ns-plain-safe-out ::= ns-char
[130]  ns-plain-char(c) ::= ( ns-plain-safe(c) - “:” - “#” )
                            ...

ns-plain-char(flow-out) ::= nb-char - s-white - “:” - “#”

But we don't see it even in examples:

- Up, up, and away!

I included whitespaces into Plain scalars as they were before my changes

@Himura2la Himura2la force-pushed the master branch 5 times, most recently from 0feaa8f to 2ec92d1 Compare June 17, 2020 09:35
@Himura2la Himura2la changed the title WIP: Fix #521 test Fix #521 test Jun 17, 2020
@Himura2la Himura2la changed the title Fix #521 test Improve Plain Style support Jun 17, 2020
rlidwka pushed a commit that referenced this pull request Dec 15, 2020
@rlidwka
Copy link
Member

rlidwka commented Dec 15, 2020

Merged into dev branch as 91f9662 (after resolving conflicts), gonna be released as 4.0 later. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants