Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper handling of character range #x10000-#x10FFFF (UTF16) #380

Closed
tedivm opened this issue Nov 19, 2017 · 2 comments
Closed

Improper handling of character range #x10000-#x10FFFF (UTF16) #380

tedivm opened this issue Nov 19, 2017 · 2 comments

Comments

@tedivm
Copy link

tedivm commented Nov 19, 2017 •
edited

According to the YAML spec the characters #x10000-#x10FFFF do not need to be escaped, yet this library is doing so.

As a second bug, the characters in this range are being encoded in a way that is not compatible with javascript. For example, that character 🎁 should be represented to javascript as \uD83C\uDF81 or \u{1F381} but is instead being sent as \U0001F381.
@puzrin
Copy link
Member

puzrin commented Nov 19, 2017 •
edited

Are you speaking about loader or dumper? Loader should support both forms. Dumper has no options to generate JS. Last related change was in #369 and i see no problems with it.

Please, provide mode details, what is wrong (because everthing seems to be ok)

@puzrin
Copy link
Member

puzrin commented Nov 21, 2017

close - no feedback.

@puzrin puzrin closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tedivm @puzrin