Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-printable/emoji characters in comments #375

Closed
brianmhunt opened this issue Oct 2, 2017 · 1 comment
Closed

Support non-printable/emoji characters in comments #375

brianmhunt opened this issue Oct 2, 2017 · 1 comment

Comments

@brianmhunt
Copy link

Following the merging of #368, non-printable characters encountered by js-yaml seem to throw an error.

I suspect that this is a breaking change that will affect a number of people who happen to have e.g. emoji in comments when they upgrade to 3.10.

Though ignoring non-printables in comments would appears to be a breach of spec, I feel that they should be acceptable (i.e. ignored), as this fix would not substantively affect the parsing or output. I noted that e.g. the Python yaml parser ignores emoji in comments.

@brianmhunt
Copy link
Author

I'm closing this because it's only reproducible on circle-ci, so I suspect it may be a package management issue. Will re-open if reproducible otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant