Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream test fails (due to bug in test) #117

Open
markstos opened this issue Aug 30, 2021 · 2 comments
Open

stream test fails (due to bug in test) #117

markstos opened this issue Aug 30, 2021 · 2 comments
Labels
pr-welcome Pull Request Welcome

Comments

@markstos
Copy link
Collaborator

This test is failing:

streams_test
    #activity()
           1) should return raw data associated to activity

URL called is like: url: 'routes/2849314360760640500/streams/?resolution=low',

Error is: StatusCodeError: 404 - {"message":"Resource Not Found","errors":[]}

From reading the API docs, it seems like routes like this should exist, so maybe it's a bug in our test.

Yep. The test contains a hardcoded activity ID, which could have only possibly worked for the original developer.

The fix would be to generate the test activity-with-segment, then run the test, then remove it.

@markstos markstos added the pr-welcome Pull Request Welcome label Aug 30, 2021
@edilson
Copy link
Contributor

edilson commented Dec 6, 2021

@markstos i believe we could improve the tests by adding a pipeline to the project, then it would be possible to add the credentials by env var and we could validate if the tests are passing or not.

@markstos
Copy link
Collaborator Author

markstos commented Dec 6, 2021

Good idea. I'm making you an owner of the new node-strava organization so you can implement it.

BTW, Strava seems not to mind if extra test accounts are created for the purpose of creating additional API keys. They are aware that my company creates them on behalf of customers so that each customer's domain has a separate API key.

Creating a test account that's used exclusively test a Node.js Strava API client seems like a fair use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-welcome Pull Request Welcome
Projects
None yet
Development

No branches or pull requests

2 participants