Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature ID: Make it a optional attribute #239

Open
psavelis opened this issue Dec 27, 2021 · 1 comment
Open

Signature ID: Make it a optional attribute #239

psavelis opened this issue Dec 27, 2021 · 1 comment

Comments

@psavelis
Copy link

psavelis commented Dec 27, 2021

Hi everyone!

According to https://www.w3.org/TR/xmldsig-core2/#sec-Overview, the ID and URL attributes are defined as optional (with a ?). I believe it should have a option/parameter to indicate whether theses attributes may be generated or not.

However, I see no option for generating and verifying a signature without theses attributes.
Is there any related issue or a fix for this requirement?

UPDATE:
Just figured out that setting isEmptyUri to true on addReference causes the ID not to render on the output, but it stills does not verify the signature.

Any fix for verifying a signed Xml, having no ID attribute on the reference node?

@cjbarth
Copy link
Contributor

cjbarth commented May 29, 2023

@psavelis , we welcome community contributions for improvements in documentation, fixes for incorrect behavior, and changes enabling additional behavior. Please consider contributing a PR with a test suite to at least recreate the weakness that you're encountering and we might be able to help you code a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants