Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If first reference matches a special case, other references are not validated #175

Open
thoro opened this issue Feb 25, 2019 · 1 comment

Comments

@thoro
Copy link

thoro commented Feb 25, 2019

Please see the following return:

https://github.com/yaronn/xml-crypto/blob/4d72940b0f0ada3a87468265b34768e8f77fd737/lib/signed-xml.js#L501

should not be there and should be replaced by a continue;

Actually, the whole if can be removed, since there's a second hash check afterwards ....

@cjbarth
Copy link
Contributor

cjbarth commented May 29, 2023

@thoro , if you have a suggestion for improvement, please considering creating a PR with a test suite so that we can review the change and get it incorporated so that the entire community can benefit from your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants