Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute value normalization in Canonicalization Algorithm #148

Open
gtkirankumar31 opened this issue Dec 14, 2017 · 1 comment
Open

attribute value normalization in Canonicalization Algorithm #148

gtkirankumar31 opened this issue Dec 14, 2017 · 1 comment

Comments

@gtkirankumar31
Copy link

With Reference to https://www.w3.org/TR/xml/#AVNormalize
we need to append a space character (#x20) for a white space character (#x20, #xD, #xA, #x9) to the normalized value. But we are also replacing multiple spaces by single space.
Need a small change in encodeSpecialCharactersInAttribute fn.

Existing code:
.replace(/[\r\n\t ]+/g, ' ')
Code change required:

.replace(/[\r\n\t ]/g, ' ')

@cjbarth
Copy link
Contributor

cjbarth commented May 29, 2023

@gtkirankumar31 , I see that you created a PR for this issue, which wasn't merged. It would be helpful if the PR included a test suite. If you're willing do so that, please reply here and we'll reopen the PR and continue work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants