Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated privateCert #569

Merged
merged 1 commit into from Mar 22, 2021

Conversation

cjbarth
Copy link
Collaborator

@cjbarth cjbarth commented Mar 19, 2021

No description provided.

@cjbarth cjbarth merged commit 5326b21 into node-saml:master Mar 22, 2021
@cjbarth cjbarth deleted the remove-deprecation-support branch March 22, 2021 15:36
@cjbarth cjbarth mentioned this pull request May 10, 2021
@cjbarth cjbarth added the semver-major This change requires at least a semver-major version bump label May 13, 2021
davidmehren added a commit to hedgedoc/hedgedoc that referenced this pull request May 17, 2021
The old `privateCert` option was removed in
node-saml/passport-saml#569

Signed-off-by: David Mehren <git@herrmehren.de>
@markstos
Copy link
Contributor

markstos commented Sep 8, 2021

If you came here looking for what to do with your old privateCert directives-- replace them with privateKey.

@markstos
Copy link
Contributor

markstos commented Sep 8, 2021

@cjbarth After this change, A grep for privateCert still returns some hits on the master branch in code and types. Is that expected? I thought this PR was removing all traces of privateCert

@cjbarth
Copy link
Collaborator Author

cjbarth commented Oct 1, 2021

I don't think that is expected. Perhaps there is something overlooked. I don't see any problems in master. Can you point me to them so I can have a further look @markstos ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major This change requires at least a semver-major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants