Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint npm script to match all files including in src/ #555

Merged
merged 1 commit into from Mar 19, 2021

Conversation

forty
Copy link
Contributor

@forty forty commented Mar 15, 2021

Description

The current lint rule misses most of the interesting lint errors (in src/) :)

@forty
Copy link
Contributor Author

forty commented Mar 15, 2021

Note that this increases the number of lint errors from 177 to 252

@cjbarth
Copy link
Collaborator

cjbarth commented Mar 15, 2021

Thanks for doing this. BTW, did you test this on Windows? I feel like you might need to replace ' with \" to get this to work on Windows and *nix.

@forty
Copy link
Contributor Author

forty commented Mar 16, 2021

@cjbarth I don't have a Windows to try that, and I have not idea how quotes work there, so I simply followed your suggestion. It seems consistent with the lint-watch script, so that's at least an improvement.

@cjbarth cjbarth merged commit 3a486db into node-saml:master Mar 19, 2021
@cjbarth cjbarth mentioned this pull request May 10, 2021
@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, etc. to keep code-rot in check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants