[BUG] Possibility to overwrite profile fields with data from attributes

[gtokarz]

Currently attributes are mapped to profile without any check, which might at best cause minor issues with previously present properties from profile object.

To Reproduce

Configure Idp/craft a SAML response with attribute Name set to i.e issuer or other profile field set before attribute mapping. Mapped profile object should now have overwritten issuer field.

Expected behavior
It should check if property already exists on the profile object and only map values when key is not present.

passport-saml/src/passport-saml/saml.ts

Line 1319 in f1a436f

attributes.forEach((attribute) => {

Environment

• Node.js version: 12.16.1
• passport-saml version: 2.0.5

[cjbarth]

@gtokarz would you be willing to create a PR with tests for this?

[gtokarz]

@cjbarth Yes, I might have some time on Monday to do so

[cjbarth]

@gtokarz We are preparing a 3.0 release. Would you be interested in getting this change up for PR in the next few weeks to make it in to 3.x?

[kriss1897]

@cjbarth @gtokarz Is it okay if I raise a PR for this?

[cjbarth]

@kriss1897 sure, anything with a pr-welcome tag we are happy to have someone help with. Please make sure to include tests for this.

[gtokarz]

yes, go ahead with PR

[kriss1897]

@cjbarth @gtokarz I've raised a PR for fixing this, however I'm unable to assign any reviewers. Please take a took when you guys have time.