Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to single line private keys on decryptionPvk #524

Open
jonathansamines opened this issue Jan 26, 2021 · 3 comments
Open

Add support to single line private keys on decryptionPvk #524

jonathansamines opened this issue Jan 26, 2021 · 3 comments

Comments

@jonathansamines
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Would be nice if decryptionPvk could be specified as a single line private key just as privateKey can be specified in a singleline.

Describe alternatives you've considered
Not applicable

@markstos
Copy link
Contributor

@jonathansamines You are welcome to submit a PR for this. Note that the first attempt to implement single-line-keys failed. Anyone implementing this should review what happened last time and what the solution was to make sure the same problem is not repeated here:

7e2de2d (scroll for discusson about the regression).

@jonathansamines
Copy link
Author

Hey @markstos I looked into 7e2de2d and looks like #423 used a different implementation (currently in use for privateKey) which seem to have solved the original problem. Would the implementation on decryptionPvk be different than the one applied to privateKey?

@markstos
Copy link
Contributor

@jonathansamines if the header and footers are the same, I presume the solution would be identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants