Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusive namespace support #164

Open
dheniges opened this issue Aug 8, 2016 · 3 comments
Open

Inclusive namespace support #164

dheniges opened this issue Aug 8, 2016 · 3 comments

Comments

@dheniges
Copy link

dheniges commented Aug 8, 2016

When computing the canonical assertion xml to validate a SAML response with the signature, the xml-crypto library requires a workaround for inclusive namespaces.

node-saml/xml-crypto#48

@dheniges
Copy link
Author

dheniges commented Aug 8, 2016

I've gone ahead and created a fix for this in case anyone else needs it: mindspacepdx#1

If this lib gets active again I'll look into adding tests and PR it here

@pdspicer
Copy link
Contributor

Hey, I'm trying to get things moving again, would be happy to see a PR for this with tests.

@misanche
Copy link

it would be nice to be included! the @dheniges mod works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants