Replies: 4 comments 8 replies
-
|
I like the |
Beta Was this translation helpful? Give feedback.
-
|
A new 3.x release with some extra logging about the chage also sounds good. "This package is deprecated, please follow these steps to switch to the scoped package...". |
Beta Was this translation helpful? Give feedback.
-
|
@markstos if you have some verbiage in mind, feel free to make a PR and I'll merge it and release it. I hesitate to do anything until we actually get 4.0 out the door though. |
Beta Was this translation helpful? Give feedback.
-
|
I think our primary line of defense against people using a deprecated package will be using NPM to properly deprecate it. I also note that there is a way to deprecate specific versions, which might make sense for everything before v3 even right now. |
Beta Was this translation helpful? Give feedback.
-
|
Sounds good to me. @cjbarth Can you deprecate 3.x? |
Beta Was this translation helpful? Give feedback.
-
|
@markstos : @cjbarth already deprecated unscoped Interesting question is whats going to happen for (unscoped) Update/edit: unscoped |
Beta Was this translation helpful? Give feedback.
-
|
@zoellner , would you consider adding a deprecation label to the unscoped Here is a reference on deprecating packages in NPM. |
Beta Was this translation helpful? Give feedback.
-
|
I thought the goal was to eventually publish this repo as node-saml but I can also just mark the old package as deprecated |
Beta Was this translation helpful? Give feedback.
-
|
It was, but moving to a namespace keeps everything consistent and makes ownership a little easier for long-term maintenance of the project/package. Thanks for doing this @zoellner . |
Beta Was this translation helpful? Give feedback.
-
|
One more thing. Dunno how this list is maintained: https://www.passportjs.org/ —> select ”Strategies” from menu or click ”View all strategies” At the moment https://www.passportjs.org/packages/passport-saml/ has Anyways if upcoming fwiw there are few documents which refer to passportjs'es |
Beta Was this translation helpful? Give feedback.
-
|
I've posted about the listed strategies: jaredhanson/passport#916 |
Beta Was this translation helpful? Give feedback.
-
passport-saml npmjs package (versions up to
3.x) is renamed (”rescoped”) to @node-saml/passport-saml npmjs package starting from4.0.0-beta.1version ( #705 ).Popular xmldom/xmldom ended up doing similar rename operation due known reason (xmldom/xmldom#271). It seems that large number/most of dependants of old npm package (
xmldom) have not picked up new npm package (@xmldom/xmldom). They have since then tried to increase visibility/awarness/discoverability of new package with renovatebot rules (xmldom/xmldom#271 (comment) and renovatebot/renovate#15588).It is obvious that
passport-saml(dependants) shall have similar issue ahead of them.This discussion thread was created to collect ideas how to increase chances that dependants of
passport-samlcould find new@node-saml/passport-samlpackage as easily as possible.Renovatebot rules are one possibility and maybe releasing e.g. new versions of 3.x and adding some info logging to it…
node-saml npm package (up to version
4.0.0-beta.2)-->@node-saml/node-saml npm package (starting from4.0.0-beta.3due node-saml/node-saml#91) has similar ”migration issue”.node-samlmight have extra issue which is related to the fact thatnode-samlnpm package is not maintained by same maintainers as npmnode-samlorganization even though at least few beta versions were released asnode-samlpackage in npmjs (node-saml/node-saml#21). I.e. could there be some challenges to get e.g. renovatebot rules accepted if renovatebot maintainers require that old maintainers of npmjs packages are the ones who request adding migration rules(?)Beta Was this translation helpful? Give feedback.
All reactions