Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Add test coverage for every exception we throw #70

Open
cjbarth opened this issue Apr 27, 2022 · 0 comments
Open

[ENHANCE] Add test coverage for every exception we throw #70

cjbarth opened this issue Apr 27, 2022 · 0 comments
Labels
enhancement New feature or request pr-welcome

Comments

@cjbarth
Copy link
Collaborator

cjbarth commented Apr 27, 2022

In order to continue ensuring that invalid conditions, which would represent security issues, are correctly detected, we need some better test coverage. Currently, we have many places where we throw exceptions if there are problems with SAML processing. However, we don't have test coverage for these conditions.

It is currently possible to modify code to allow an unsafe condition through as valid SAML and still have all the existing tests pass. It is very difficult to catch such cases in code review. Thus, we need to add tests that will cover every exception that we throw so that we can ensure these invalid cases are always detected correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr-welcome
Projects
None yet
Development

No branches or pull requests

1 participant