Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling by throwing a custom error class: NodeSamlError. #57

Open
cjbarth opened this issue Apr 4, 2022 · 0 comments
Open

Improve error handling by throwing a custom error class: NodeSamlError. #57

cjbarth opened this issue Apr 4, 2022 · 0 comments
Labels
enhancement New feature or request pr-welcome

Comments

@cjbarth
Copy link
Collaborator

cjbarth commented Apr 4, 2022

Per the suggestion from @markstos , node-saml should throw a custom error that inherits from Error called NodeSamlError instead of Error. For the scope of this PR, it is expected there should be no additional properties on NodeSamlError.
@cjbarth cjbarth added the enhancement New feature or request label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pr-welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjbarth