Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup discussion from passport-saml PR #2

Closed
kriss1897 opened this issue May 19, 2021 · 2 comments
Closed

Followup discussion from passport-saml PR #2

kriss1897 opened this issue May 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kriss1897
Copy link
Contributor

PR: node-saml/passport-saml#574
@kriss1897 kriss1897 added the enhancement New feature or request label May 19, 2021
@kriss1897 kriss1897 mentioned this issue May 19, 2021
Merged
3 tasks
zoellner added a commit that referenced this issue May 19, 2021
@zoellner
remove passport-saml code and tests
60af4cc 
move node-saml code and tests up one level to src/ and test/
create passport-saml-types
reset changelog
rename package to node-saml
#2
@zoellner zoellner mentioned this issue May 19, 2021
Merged
@cjbarth
Copy link
Collaborator

cjbarth commented May 20, 2021

The node-saml and passport-saml projects are accepting all PRs that actually complete the separateion of the Node-SAML stuff from the Passport stuff. We wish to make a pair of 4.0.0 releases that complete this separation and where node-saml is a dependency of passport-saml.

@kriss1897
Copy link
Contributor Author

@zoellner @cjbarth Guys, who will be able to review the PRs? node-saml/passport-saml#593 and #5

@cjbarth cjbarth closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjbarth @kriss1897