Replies: 1 comment 5 replies
-
There have been some updates in |
Beta Was this translation helpful? Give feedback.
5 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi,
Having recently made the switch from
node-saml@4.0.0-beta.2
to@node-saml/node-saml
, we discovered one of our clients hit a problem with validating their signature. I bisected it back to #38.Their certificate is included in the XML with
characters in it, very much like the one you can see in keycloak/keycloak#14529 (comment) (that's an unrelated issue we stumbled upon while debugging the matter). They seem to suggest it's valid, samltool also validates the XML of our client with those entities untouched, but node-saml now doesn't after this PR.I'm a bit lost as to who's right. Was this PR actually correct, and if so, would the bug actually be in xml-crypto?
Any help appreciated.
Beta Was this translation helpful? Give feedback.
All reactions