fix: 🐛 should trigger response event when follow redirect #361
+102
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
===========================================
+ Coverage 44.05% 93.17% +49.11%
===========================================
Files 6 6
Lines 799 820 +21
Branches 218 221 +3
===========================================
+ Hits 352 764 +412
+ Misses 447 56 -391
Continue to review full report at Codecov.
|
denghongcai
changed the title
denghongcai
changed the title
dead-horse
reviewed
Jun 4, 2021
test/urllib_promise.test.js
Outdated
| @@ -38,6 +38,7 @@ describe('test/urllib_promise.test.js', function () { | |||
| timeout: 20000 | |||
| }) | |||
| .then(function (result) { | |||
| console.dir(result); | |||
dead-horse
approved these changes
Jun 7, 2021
|
2.37.2 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
现有 followRedirect 的情况下，response 事件只会触发一次（redirect 之后的请求的 response），request 会触发两次（redirect 前请求的 resquest 和 request 之后的 response）