Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: definition error #87

Merged
merged 1 commit into from Apr 25, 2020
Merged

fix: definition error #87

merged 1 commit into from Apr 25, 2020

Conversation

whxaxes
Copy link
Contributor

@whxaxes whxaxes commented Apr 23, 2020

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix : #76

@whxaxes whxaxes requested review from fengmk2 and ngot April 23, 2020 03:09
@whxaxes
Copy link
Contributor Author

whxaxes commented Apr 23, 2020

Unittest for ts has passed

@ngot
Copy link
Member

ngot commented Apr 23, 2020

Since Github Actions added in this PR, Travis and Appveyor can be removed I think. The badge in readme.md also needs to be updated.

@fengmk2 fengmk2 merged commit bbd20c0 into master Apr 25, 2020
@fengmk2 fengmk2 deleted the fix-d-ts branch April 25, 2020 12:51
@fengmk2
Copy link
Member

fengmk2 commented Apr 25, 2020

4.1.1

This was referenced Apr 25, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@ngot ngot Awaiting requested review from ngot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript import not clear/broken?
3 participants
@whxaxes @ngot @fengmk2