Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Node 10 APIs #83

Closed
AxelTerizaki opened this issue Dec 2, 2019 · 4 comments
Closed

Support for Node 10 APIs #83

AxelTerizaki opened this issue Dec 2, 2019 · 4 comments

Comments

@AxelTerizaki
Copy link

Judging from this comment on got's v10 beta ( sindresorhus/got#876 ), agentkeepalive does not use Node 10's APIs.

Could it be possible to add that support so we can upgrade to got v10 on our app ?

Thanks in advance.

@kennethaasan
Copy link

Not sure if this is a problem with agentkeepalive. I eventually found out that my issue in sindresorhus/got#876 (comment) is related to using New Relic (https://github.com/newrelic/node-newrelic)

@AxelTerizaki
Copy link
Author

Oh, I'll have to test it out then, and see what happens, I guess. I'll try to test it this weekend, and if it still works after upgrading to Got 10 then I'll close this issue.

Thanks for the feedback.

@kennethaasan
Copy link

@AxelTerizaki
Copy link
Author

Seems to work well, so I'm closing it. Sorry for opening it in the first place :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants