Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Zero length deflate responses are never fulfilled #922

Closed
nsmaciej opened this issue Sep 2, 2020 · 1 comment · Fixed by #965
Closed

Bug: Zero length deflate responses are never fulfilled #922

nsmaciej opened this issue Sep 2, 2020 · 1 comment · Fixed by #965

Comments

@nsmaciej
Copy link
Contributor

nsmaciej commented Sep 2, 2020

Some older ISS servers can send zero-length deflate responses. This causes the response to ‘slip through the cracks’, leading to the response promise to never be fulfilled.

I created a PR #903 to fix this over a month ago, but I am creating an issue due to inactivity.

Reproduction

More detail can be be found in the PR. This affects both version 2.x and 3.x. Essentially any response similar to

HTTP/1.1 200 OK
Content-Encoding: deflate
Content-Length: 0
Server: Microsoft-IIS/7.5

Expected behaviour

The node-fetch response promise should be fulfilled.

@github-actions
Copy link

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant