Export package.json #908
Merged
Export package.json #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Richienb
reviewed
Aug 2, 2020
| ".": { | ||
| "import": "./src/index.js", | ||
| "require": "./dist/index.cjs" | ||
| }, | ||
| "./package.json": "./package.json" |
There was a problem hiding this comment.
Are we able to remove this then?
There was a problem hiding this comment.
I don't understand the question, sorry
There was a problem hiding this comment.
Are we now able to remove "./package.json": "./package.json"?
There was a problem hiding this comment.
That's one of the main things I'm adding in this PR. It's essential to achieving the aims of the PR, namely being able to import/require 'node-fetch/package.json' in nodejs 12.7.0+
|
Member of the Node.js modules team here. It is likely a very good idea to land this change. |
xxczaki
approved these changes
Aug 6, 2020
jimmywarting
approved these changes
Aug 6, 2020
|
@jimmywarting Are you able to release a new beta containing this update? |
Merged
|
@wheresrhys See #912 |
|
Thank you |
|
@wheresrhys Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907 (see the issue for context)