Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove string-to-arraybuffer test dependency #882

Merged
merged 1 commit into from Jun 13, 2020
Merged

chore: remove string-to-arraybuffer test dependency #882

merged 1 commit into from Jun 13, 2020

Conversation

tinovyatkin
Copy link
Member

This PR removes external test dependency string-to-arraybuffer in favor of Node.js built-in util.TextEncoder available since Node 8.30

@tinovyatkin tinovyatkin added enhancement dependencies Pull requests that update a dependency file labels Jun 13, 2020
Copy link
Collaborator

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

fyi, here is something i picked up long ago:

var encode = TextEncoder.prototype.encode.bind(new TextEncoder())
encode('text').buffer

nicer to have then having to construct a new encoder all the time and reuse the same one. But the way you have done it is okey also.

@tinovyatkin tinovyatkin merged commit 96431ed into node-fetch:master Jun 13, 2020
@tinovyatkin tinovyatkin deleted the remove-string-to-arraybuffer branch June 13, 2020 07:13
Copy link
Member

@NotMoni NotMoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants