fix: min semver Node version #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxczaki
approved these changes
Jun 11, 2020
jimmywarting
approved these changes
Jun 11, 2020
That should be changed by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wrong with my understanding of what backported means in Node.js versions and
Readable.fromseems to skip the whole range of Node 11 (reached end of life already) and 3 earlier versions of Node 12.This PR fixes that and removes the unneeded exemption from
eslint-plugin-noderules.Not sure why diff become crazy here 馃槙Unrelated change to prevent such diffs in the future: added
package.jsoninto oureditorconfig.