New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Should check body _source_ on redirect #866
[Spec] Should check body _source_ on redirect #866
Conversation
@node-fetch/reviewers Could you please take a look at this PR? |
I just have a few questions as to why we are bumping up the dependencies? |
@tinovyatkin @larson-carter wants to know why the minimum version of Node.js is being increased. |
He already answered this question.
|
What is the purpose of this pull request?
While working on #210 I went into a particular interpretation of fetch redirect step 9.
fetch standard:
However, our source instead of body source is checking created
Request.body
. This PR fixes that fact.This is also important due to fact that we may (want) convert the body to a stream internally, so, we actually must check body source here.
In addition, well-outdated test dependency
resumer@0.0.0
was replaced with nativeReadable.from
.In addition, while doing the above replacement, the hacky test for
Buffer.concat
failure was replaced with the correct implementation of the stream that can't be concatenated into a buffer.This PR also bumps Node.JS minimum version to 10.17 from 10.16 (will also be required for #603 and for #210).