Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Code of Conduct #849

Merged
merged 1 commit into from May 29, 2020
Merged

Create Code of Conduct #849

merged 1 commit into from May 29, 2020

Conversation

tinovyatkin
Copy link
Member

@tinovyatkin tinovyatkin commented May 29, 2020

Doing my compulsory social work 馃槉 as my apologies over two inappropriate tone comments in recent PRs. Not sure which email address we should put here for enforcement, so, I've put @jimmywarting who very politely called my attention on this matter.

Doing my compulsory social work as my apologies over two inappropriate tone comments in recent PRs. Not sure which email address we should put here for enforcement, so, I've put @jimmywarting who very politely called my attention on this matter.
@jimmywarting
Copy link
Collaborator

I have mostly seen myself as a moderator to this repo.

In the beginning bitinn didn't want to adapt es6 syntax way back when we had lower node support, so i didn't want to code with es3-5 style or what it was. but look at us now :)
but i felt like i wanted to help out in any way i could by:

  • keeping track of most things like issues and PR
  • making sure we follow the specification
  • trying to keep none spec things from ever entering into node-fetch
  • giving out suggestion, helping others with questions folks may have.
  • format others comment so code blocks looks good.
  • reviewing others code.
  • making sure we keep a good tone

if i see some issue, pr or comment then i try to ask myself

  • will this have any value
  • can it be solved in any another way
  • have this been brought up before
    instead of flatt out reject/close something i try to give folks a fighting chans to explain themself of why zyx would be useful or better.

If i would help out making commits then it would take too much time from me.

I'm also quite active on Stackoverflow, before i was the one to ask question but when i became good at javascript, html & css then i started to help out others and now have a score of 19k points :)

Copy link
Collaborator

@jimmywarting jimmywarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now as for my review, i think we should rename it to CONTRIBUTING.md and stuff it into the .github directory 馃憤

https://github.blog/2012-09-17-contributing-guidelines/

@tinovyatkin
Copy link
Member Author

tinovyatkin commented May 29, 2020

@jimmywarting the Code of Conduct and Contributor Guidelines are different things from GitHub point of view: https://github.com/node-fetch/node-fetch/community
This one actually was generated automatically from the GitHub template for Code of Conduct, so, I assume naming is correct.

@jimmywarting
Copy link
Collaborator

Oh, okey, take it back

@xxczaki xxczaki merged commit bab5fdc into master May 29, 2020
@xxczaki xxczaki deleted the add-code-of-conduct branch May 29, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants