Drop custom Promises and refactor to async functions
#845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinovyatkin
changed the title
async functions
Richienb
previously requested changes
May 28, 2020
LinusU
reviewed
May 28, 2020
test/main.js
Outdated
| @@ -601,8 +601,9 @@ describe('node-fetch', () => { | |||
| return fetch(url).then(res => { | |||
| expect(res.status).to.equal(200); | |||
| expect(res.ok).to.be.true; | |||
| return expect(res.text()).to.eventually.be.rejectedWith(Error) | |||
| .and.have.property('message').includes('Premature close'); | |||
There was a problem hiding this comment.
Hmmm, this should still reject with an error, right? Seems like the new code is missing to check for errors at some point? 🤔
There was a problem hiding this comment.
It's Draft PR, not ready for review yet 😄
But yes, I'm struggling to understand expected behavior with a partial body. Do we need to put a partial body somewhere or just discard it?
There was a problem hiding this comment.
Hehe, sorry, I was a bit eager 😁
I think that we can just discard it, since the request have errored 🤔
tinovyatkin
changed the title
async functionsasync functions
jimmywarting
approved these changes
May 28, 2020
jimmywarting
requested changes
May 28, 2020
xxczaki
approved these changes
May 28, 2020
LinusU
approved these changes
May 28, 2020
jimmywarting
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844 and drops custom Promises.
This PR didn't complete the refactoring of
index.jsintoasyncfunction (as it way more complicated and time-consuming task), but it can be done by iterations later on as non-breaking changes, now when we drop support for custom promises.No changes to tests, except for the removal of testing for custom promises.