Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CommonJS build artifact #838

Merged
merged 2 commits into from May 26, 2020
Merged

Test CommonJS build artifact #838

merged 2 commits into from May 26, 2020

Conversation

tinovyatkin
Copy link
Member

@tinovyatkin tinovyatkin commented May 25, 2020

What is the purpose of this pull request?

  • Bug fix
  • Other, please explain:

What changes did you make? (provide an overview)

These changes add a script that builds and tests the fitness of CommonJS build artifact at prepublishOnly command.
Should prevent incidents like #836

Comes with GitHub Action watchdog for build-related files

@tinovyatkin tinovyatkin changed the title test-commonjs Test CommonJS Build Artefact May 25, 2020
Copy link
Member

@xxczaki xxczaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, this will definitely help a lot 👍

@tinovyatkin tinovyatkin requested a review from Richienb May 25, 2020 20:54
@Richienb Richienb changed the title Test CommonJS Build Artefact Test CommonJS build artifact May 26, 2020
@JefferyHus
Copy link
Member

Cool 👍

@xxczaki xxczaki merged commit 966a4c3 into node-fetch:master May 26, 2020
@tinovyatkin tinovyatkin deleted the test-commonjs branch May 26, 2020 17:17
@tinovyatkin tinovyatkin mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants