Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Host header as the first header #1570

Open
AlttiRi opened this issue May 31, 2022 · 5 comments
Open

Send Host header as the first header #1570

AlttiRi opened this issue May 31, 2022 · 5 comments
Labels
bug good first issue help wanted

Comments

@AlttiRi
Copy link

AlttiRi commented May 31, 2022 •
edited

The minor issue from #1569.

Currently it sends Host header as the last header. (If a user did not add it manually)

I think it should send Host header as the first header like it browsers and other libraries do.

Prepend it instead of appending.

"node-fetch": "3.2.3"
@AlttiRi AlttiRi added the bug label May 31, 2022
@skullkim
Copy link

skullkim commented Oct 8, 2022

I would like to work on this issue.

@LinusU
Copy link
Member

LinusU commented Oct 8, 2022

@skullkim feel free to send a PR, I'd be happy to review it!

@nallammai-maruthappan
Copy link

I would like to contriibute to this issue

@LinusU
Copy link
Member

LinusU commented Oct 19, 2022

@nallammai-maruthappan feel free to send a PR, I'd be happy to review it!

@nvspradeep
Copy link

@LinusU looks like someone already sent a PR for this -> #1662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LinusU @AlttiRi @nvspradeep @skullkim @nallammai-maruthappan