fix: cancel request example import #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoftwareAndOutsourcing
changed the title
|
Hmm, wondering if not we should try to fix the real problem that is that we return a custom AbortError message, it should rather be a // Browser test:
ctrl = new AbortController()
ctrl.abort()
fetch('/', ctrl).catch(console.log)
// DOMException {
// name: AbortError,
// code: 20,
// message: "Failed to execute 'fetch' on 'Window': The user aborted a request."
// }We could optionally start to depend on node-domexception. it's already included by another sub dependency of ours (fetch-blob). |
LinusU
reviewed
Feb 28, 2022
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
|
@jimmywarting I think that would be nice, but I still think that we should merge this one in the mean time 👍 |
|
Alright. maybe change it in next major release to avoid breakage? |
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
should maybe have done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes cancel request example import.