Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export Blob, File and FormData + utilities #1463

Merged
merged 6 commits into from Jan 20, 2022
Merged

feat: export Blob, File and FormData + utilities #1463

merged 6 commits into from Jan 20, 2022
+27 −21

Conversation

jimmywarting
Copy link
Collaborator

Purpose

Making it easier to import and use FormData, Blob & File. Installing same dependency as node-fetch or otherwise getting them in a round-about way was hacky.

Changes

This re-export the stuff so it is available to use

  • I updated readme
  • I added unit tests (for FormData, Blob, and fileFrom only)

@jimmywarting jimmywarting changed the title Features/export more stuff feat: export Blob, File and FormData + utilities Jan 18, 2022
jimmywarting
jimmywarting commented Jan 18, 2022
View reviewed changes
src/index.js Outdated Show resolved Hide resolved
LinusU
LinusU approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@jimmywarting jimmywarting merged commit 81b1378 into node-fetch:main Jan 20, 2022
@jimmywarting jimmywarting deleted the features/export-more-stuff branch January 20, 2022 20:42
@github-actions
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimmywarting
Copy link
Collaborator Author

☝️ Neat

@gulshan
Copy link

gulshan commented Jan 21, 2022

Hi, vscode/typescript cannot see these newly exported types-
image

Can you have a look?

@jimmywarting
Copy link
Collaborator Author

@gulshan Already got it covered in #1465
i thought i would document it in the next release when it was released so that the readme would not show something that haven't been shipped yet. But now that we have auto deployment with auto releasees then i think things will change around here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose more stuff (Blob, File & FormData)
3 participants
@jimmywarting @gulshan @LinusU