Fetch never resolves on empty response with deflate

[szmarczak]

const fetch = require('node-fetch');
const http = require('http');

const server = http.createServer((request, response) => {
        response.setHeader('content-encoding', 'deflate'); // change this to gzip and it works
        response.end();
});

server.listen(8080);

(async () => {
        const response = await fetch('http://localhost:8080');
        const text = await response.text();

        console.log('Result:', text);

        server.close();
})();

Looks like you're missing

+				let hasData = false;
				raw.once('data', chunk => {
+					hasData = true;
					// See http://stackoverflow.com/questions/37519828
					body = (chunk[0] & 0x0F) === 0x08 ? pump(body, zlib.createInflate(), reject) : pump(body, zlib.createInflateRaw(), reject);

					response = new Response(body, responseOptions);
					resolve(response);
				});
+
+				raw.once('end', () => {
+					if (!hasData) {
+						response = new Response(body, responseOptions);
+						resolve(response);
+					}
+				});

before

node-fetch/src/index.js

Line 292 in 41f53b9

return;

[JefferyHus]

Good catch there, @jimmywarting if you confirm, I would love to take care of fixing this

[bitinn]

@JefferyHus sounds fair, you can go ahead with the PR :)

[jimmywarting]

closing as dupl of #965

[github-actions]

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀